Fix the displayed loss in the sft trainer for gradient accumulation > 1 #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR mainly fixes the display loss value in the
fsdp_sft_trainer. We should sum up the scaled values rather than directly use the scaled one. By the way, we also performed an all reduce operation to average the loss values among DP nodes.Environment
Reproduction
torchrun --standalone --nnodes=1 --nproc_per_node=4 \ -m verl.trainer.fsdp_sft_trainer \ data.train_files=$HOME/data/gsm8k/train.parquet \ data.val_files=$HOME/data/gsm8k/test.parquet \ data.prompt_key=prompt \ data.response_key=answer \ data.micro_batch_size=8 \ model.partial_pretrain=meta-llama/Meta-Llama-3-8B-Instruct \ trainer.project_name=gsm8k-sft \ trainer.experiment_name=llama3_gsk8k_before_fix \ trainer.total_epochs=4 \ trainer.logger=['console','wandb']The training loss of Llama-3 8B on the GSM8K dataset should be larger than 0.5, while the bugged version has much lower loss values.
Who can review?
@PeterSH6